Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOPID-1192] added optional field to endpoint notify-login #288

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

arcogabbo
Copy link
Contributor

List of Changes

Motivation and Context

enable fallback login email template to be sent if an user doesn't have a validated email

How Has This Been Tested?

unit tests

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

github-actions bot commented Dec 1, 2023

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1192

@arcogabbo arcogabbo force-pushed the IOPID-1192--added-optional-field-to-endpoint branch from e633650 to e305d84 Compare December 19, 2023 13:39
Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gquadrati gquadrati merged commit 7a1e9c8 into master Dec 19, 2023
4 checks passed
@gquadrati gquadrati deleted the IOPID-1192--added-optional-field-to-endpoint branch December 19, 2023 14:15
magicCodeActivityResult
);
if (E.isRight(errorOrMagicLinkServiceResponse)) {
if (errorOrMagicLinkServiceResponse.right.kind === "SUCCESS") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (errorOrMagicLinkServiceResponse.right.kind === "SUCCESS") {
const magicLinkServiceResponse = errorOrMagicLinkServiceResponse.right;
if (magicLinkServiceResponse.kind === "SUCCESS") {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants